signed ops is not working in RTL

Question

signed ops is not working in RTL

Closed this issue 5 years ago · 8 comments

Kuree commented 5 years ago

Probably the same issue with asr.

I haven't test smin yet, but I'm suspecting it's the same error.

See smax branch.

See: https://travis-ci.com/StanfordAHA/lassen/builds/111969902

Answer 1 · 2019-05-15T19:57:54.000Z

List of additional ops that doesn't work:

~~slt~~
~~sle~~
smax
smin

Answer 2 · 2019-05-15T20:07:06.000Z

I suspect this is a similar issue to asr w.r.t. to polymorphism

Answer 3 · 2019-05-15T20:13:35.000Z

Fixed by df0d387, @Kuree I can pull it in, but I didn't see the tests for slt, sle, smin. Are they on a separate branch? Or could you push them.

Answer 4 · 2019-05-15T20:14:26.000Z

I'll push them. I only have them on end-to-end tests. I will make unit tests.

Answer 5 · 2019-05-15T20:16:12.000Z

Okay thanks, probably easiest to push them to the smax branch

Answer 6 · 2019-05-15T20:33:39.000Z

Pushed. My mistake on slt and sle, I was using the wrong condition code. So far only smax and smin is not working.

Question though, why sle and slt doesn't have signed set in asm.py?

Answer 7 · 2019-05-15T20:35:59.000Z

That's likely a bug in the asm.py definition, but I'm not sure what the spec is supposed to be

Answer 8 · 2019-05-15T21:01:45.000Z

I do not think that SLE nor SLT needs the signed bit set. The flags should be appropriately set based off of the subtract. Possibly a bug in the flags.