StylishThemes/Wikipedia-Dark

various issues on german wiki - bright background/missing colors

hauk92 opened this issue · 1 comments

AfroThundr3007730 commented

@hauk92 So the first half of the issue is solved now, albeit with a lot more !important rules than I would like. This is why I don't like inline styles, but it seems dewiki hasn't fully joined the TemplateStyles trend yet.

As for the second part of the issue, fixing those pie charts and bar graphs would essentially require exempting those specific colors from the generic div[style*="background:"] rule, which will probably poke holes in the style elsewhere. If there were some classes or something to write a selector against, it'd be a different story.

The image background contrast issue is a war that has been waged since this style was first started, and no matter what we do, there will always be images that have the wrong background. We can add selectors specifically for those images, but more will appear. Or we could just make all thumbnail backgrounds white and override this rule for dewiki.

If you've got a better method of fixing those, feel free to submit a PR, but for now I'm going to leave them be.

  • ❤️1