Sylius/PayPalPlugin

Wrong service injection for controller CompletePayPalOrderFromPaymentPageAction

DjLeChuck opened this issue · 0 comments

Hi,

The controller Sylius\PayPalPlugin\Controller\CompletePayPalOrderFromPaymentPageAction has an attribute $orderManager wich is wrongly injected.

The service fos_oauth_server.entity_manager is used instead of sylius.manager.order which makes the application crash when the API of Sylius is deactivated.

        <service id="Sylius\PayPalPlugin\Controller\CompletePayPalOrderFromPaymentPageAction" public="true">
            <argument type="service" id="Sylius\PayPalPlugin\Manager\PaymentStateManagerInterface" />
            <argument type="service" id="router" />
            <argument type="service" id="Sylius\PayPalPlugin\Provider\OrderProviderInterface" />
            <argument type="service" id="sm.factory" />
            <argument type="service" id="fos_oauth_server.entity_manager" />
        </service>

I will open a PR later today. 👍