awesome plugin

Question

awesome plugin

Closed this issue 6 years ago · 24 comments

Looks very clean compare with the official one, it would be good if you could do some docs for it, i have a looked around and just don't know where to start with this

Answer 1 · 2018-05-21T07:36:15.000Z

Hi Jason!

For examples, please take a look at test folder

Answer 2 · 2018-05-21T07:38:03.000Z

Cheers for the reply I did that, the test seems for server side codes, I have try it with react, it doesn’t go well with the test code Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 3:36 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) Hi Jason! For examples, please take a look at test folder — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg8wGtQc7LNZwfRPd3ZWPrNI6-O0Ydks5t0m5ygaJpZM4UGeEc>.

Answer 3 · 2018-05-21T07:40:47.000Z

Those test are running in browser, see test/buildtest.js

Answer 4 · 2018-05-21T07:41:44.000Z

When I build for react this comes up ./node_modules/ws/lib/buffer-util.js Module not found: Can't resolve 'bufferutil' in '/Volumes/DEVELOPMENT/react/web/webrtc/node_modules/ws/lib' ./node_modules/ws/lib/validation.js Module not found: Can't resolve 'utf-8-validate' in '/Volumes/DEVELOPMENT/react/web/webrtc/node_modules/ws/lib' Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 3:40 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) Those test are running in browser, see test/buildtest.js — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg86HvnLZSLNzDVcqh8Ywxzs_bpp0Lks5t0m-DgaJpZM4UGeEc>.

Answer 5 · 2018-05-21T07:42:56.000Z

Which node version are you using?

Answer 6 · 2018-05-21T07:44:47.000Z

8.1.1 Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 3:42 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) Which nodr version are you using? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg8-zKgYqJ_0D9w4Jrk935yFWhPj6Aks5t0nAAgaJpZM4UGeEc>.

Answer 7 · 2018-05-21T07:51:58.000Z

we use ws library on nodejs side to have websocket, in the browser we did not need it. You can check: https://github.com/TechTeamer/janus-api/blob/master/src/WebSocket.js

Try not to include ws in the build

Answer 8 · 2018-05-21T07:56:02.000Z

Got it as ws is included in the npm package how would I exclude it with the react build Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 3:52 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) we use ws library on nodejs side to have websocket, in the browser we did not need it. You can check: https://github.com/TechTeamer/janus-api/blob/master/src/WebSocket.js Try not to include ws in the build — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg83OvT9Gnnvdum4zrXNqjNkpyiLIMks5t0nIggaJpZM4UGeEc>.

Answer 9 · 2018-05-21T08:12:14.000Z

May be this can help: socketio/socket.io-client#933

Answer 10 · 2018-05-21T08:29:59.000Z

Yeah I have read that, but I am not using webpack so not sure where to go from here Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 4:12 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) May be this can help: socketio/socket.io-client#933<socketio/socket.io-client#933> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg8-2jTtEkUrf3YiLzYbK54EZiSpLEks5t0nbjgaJpZM4UGeEc>.

Answer 11 · 2018-05-21T08:32:41.000Z

How do you build?

…

On Mon, May 21, 2018, 10:30 jason-shen ***@***.***> wrote: Yeah I have read that, but I am not using webpack so not sure where to go from here Kind Regards, ***@***.*** From: Gábor Tóth ***@***.***> Reply-To: TechTeamer/janus-api ***@***.***> Date: Monday, May 21, 2018 at 4:12 PM To: TechTeamer/janus-api ***@***.***> Cc: jason-shen ***@***.***>, Author < ***@***.***> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) May be this can help: socketio/socket.io-client#933< socketio/socket.io-client#933> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< #9 (comment)>, or mute the thread< https://github.com/notifications/unsubscribe-auth/ABtg8-2jTtEkUrf3YiLzYbK54EZiSpLEks5t0nbjgaJpZM4UGeEc>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALajrsYhcMCIdS5NRGKBeXK5x8aw02oks5t0nsLgaJpZM4UGeEc> .

Answer 12 · 2018-05-21T08:37:50.000Z

Create-react-app The cli of react does the building "scripts": { "start": "react-scripts start", "build": "react-scripts build --exclude=node_modules/ws", "test": "react-scripts test --env=jsdom", "eject": "react-scripts eject" }, Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 4:32 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) How do you build?

On Mon, May 21, 2018, 10:30 jason-shen ***@***.***> wrote: Yeah I have read that, but I am not using webpack so not sure where to go from here Kind Regards, ***@***.*** From: Gábor Tóth ***@***.***> Reply-To: TechTeamer/janus-api ***@***.***> Date: Monday, May 21, 2018 at 4:12 PM To: TechTeamer/janus-api ***@***.***> Cc: jason-shen ***@***.***>, Author < ***@***.***> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) May be this can help: socketio/socket.io-client#933< socketio/socket.io-client#933> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< #9 (comment)>, or mute the thread< https://github.com/notifications/unsubscribe-auth/ABtg8-2jTtEkUrf3YiLzYbK54EZiSpLEks5t0nbjgaJpZM4UGeEc>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALajrsYhcMCIdS5NRGKBeXK5x8aw02oks5t0nsLgaJpZM4UGeEc> .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg8xRWd5lOUS3wkfHSv9URtVWxfbxkks5t0nuqgaJpZM4UGeEc>.

Answer 13 · 2018-05-21T09:29:10.000Z

I've successfully built sample react app by putting externals: ['ws'] line in the webpack configuration node_modules/react-scripts/config/webpack.config.dev.js

Answer 14 · 2018-05-21T09:43:14.000Z

however i couldn't find a way how to override that webpack config :S
but this is a quick and dirty solution:

  "scripts": {
    "start": "rm -rf ./node_modules/ws && react-scripts start",
    "build": "rm -rf ./node_modules/ws && react-scripts build",
    "test": "react-scripts test --env=jsdom",
    "eject": "react-scripts eject"
  }

Answer 15 · 2018-05-21T10:12:49.000Z

cool will give that a go thanks 发自我的iPhone

…

------------------ Original ------------------ From: Gábor Tóth <notifications@github.com> Date: Mon,May 21,2018 5:43 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) however i couldn't find a way how to override that webpack config :S but this is a quick and dirty solution: "scripts": { "start": "rm -rf ./node_modules/ws && react-scripts start", "build": "rm -rf ./node_modules/ws && react-scripts build", "test": "react-scripts test --env=jsdom", "eject": "react-scripts eject" } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg86IOy8D-2pOGPZ9HybP3HhNTTI9lks5t0owygaJpZM4UGeEc>.

Answer 16 · 2018-05-21T11:07:45.000Z

Try it but your lib don’t like it here is the error ./node_modules/@techteamer/janus-api/src/WebSocket.js Module not found: Can't resolve 'ws' in '/Volumes/DEVELOPMENT/react/web/webrtc/node_modules/@techteamer/janus-api/src' Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 5:43 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) however i couldn't find a way how to override that webpack config :S but this is a quick and dirty solution: "scripts": { "start": "rm -rf ./node_modules/ws && react-scripts start", "build": "rm -rf ./node_modules/ws && react-scripts build", "test": "react-scripts test --env=jsdom", "eject": "react-scripts eject" } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg86IOy8D-2pOGPZ9HybP3HhNTTI9lks5t0owygaJpZM4UGeEc>.

Answer 17 · 2018-05-21T12:09:58.000Z

This actually worked thanks Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 5:29 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) I've sucsessfully built sample react app by putting externals: ['ws'] line in the webpack configuration node_modules/react-scripts/config/webpack.config.dev.js — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg84aGbJ4xFYdEUvwhhp2OsVmpNireks5t0ojngaJpZM4UGeEc>.

Answer 18 · 2018-05-21T19:56:27.000Z

Hi Gabor I am playing around with the awesome lib, just wondering, any chance implementing the rest of the plugins, like video/voice calls between user and sip That would be great if you can thanks Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 5:43 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) however i couldn't find a way how to override that webpack config :S but this is a quick and dirty solution: "scripts": { "start": "rm -rf ./node_modules/ws && react-scripts start", "build": "rm -rf ./node_modules/ws && react-scripts build", "test": "react-scripts test --env=jsdom", "eject": "react-scripts eject" } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg86IOy8D-2pOGPZ9HybP3HhNTTI9lks5t0owygaJpZM4UGeEc>.

Answer 19 · 2018-05-23T07:25:58.000Z

I have manage to get it running, with couple of problems, 1. Only I can publish or listen to the room, others can’t seem to join 2. Please see the image I have a error log coming back from the server, not sure what that means Any help would be great, thanks advance Kind Regards, [cid:image001.png@01D3E3F3.37DF5E60] From: Gábor Tóth <notifications@github.com> Reply-To: TechTeamer/janus-api <reply@reply.github.com> Date: Monday, May 21, 2018 at 5:29 PM To: TechTeamer/janus-api <janus-api@noreply.github.com> Cc: jason-shen <jason_2000_nz@hotmail.com>, Author <author@noreply.github.com> Subject: Re: [TechTeamer/janus-api] awesome plugin (#9) I've sucsessfully built sample react app by putting externals: ['ws'] line in the webpack configuration node_modules/react-scripts/config/webpack.config.dev.js — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABtg84aGbJ4xFYdEUvwhhp2OsVmpNireks5t0ojngaJpZM4UGeEc>.

Answer 20 · 2018-05-23T10:12:03.000Z

For one client you should create a publisher and several listeners

Answer 21 · 2018-05-23T11:06:16.000Z

also have you come across this error?

Answer 22 · 2018-05-23T11:42:04.000Z

yep, its not a real error. slow_link means that janus discovered that one of the connection is weak.

Answer 23 · 2018-05-23T11:51:30.000Z

ok so its good then, if reduce the video res should be fix this warning right

Answer 24 · 2018-05-23T12:01:23.000Z

one more question while i have you online

if want to make a video chat(more than one publisher) just do more than one publisher, is that correct.
is it possible to do 1 one 1 call with the plugin