Bug in rendering Guid? property types

Question

Bug in rendering Guid? property types

Closed this issue 5 years ago · 3 comments

Think PropertyGenerator::Create contains a bug for a property of Guid? type. It is rendered like this in code file: Nullable'1

For primitive datatypes it goes perfectly well...

Answer 1 · 2019-10-15T21:30:39.000Z

Adding this:

if (type == typeof(Guid))
{
typeSyntax = IdentifierName("Guid");
}

to TypeGenerator::CheckPredefinedTypes, after all the other checks, appears to solve the issue

Answer 2 · 2019-10-16T04:38:23.000Z

Nice find, can you create a PR with the fix + a test in TypeGeneratorTests.cs? If not I can do it later today.

Answer 3 · 2019-10-16T16:50:37.000Z

I found some time to check on it and it seems like we don't support structs that well (or well nullable structs). So I added support for that but made some specific tests for GUID as it's a pretty normal struct to use.