ThatInheritFrom - fails on multiple types

Question

ThatInheritFrom - fails on multiple types

Closed this issue 3 years ago · 6 comments

i think the fix would be

file: src/Testura.Code/Builders/Base/TypeBuilderBase.cs
line: 183

                syntaxNodeOrToken[n] = SyntaxFactory.SimpleBaseType(TypeGenerator.Create(_inheritance[n / 2]));
                if (n + 1 < (_inheritance.Count * 2) - 1)

Answer 1 · 2020-07-08T10:17:12.000Z

Oh thanks I will check it out and make a fix.

Answer 2 · 2020-07-09T00:49:08.000Z

LINQ approach - should give the same result

    protected BaseListSyntax CreateBaseList() =>
        _inheritance.Any()
            ? SyntaxFactory.BaseList(
                SyntaxFactory.SeparatedList<BaseTypeSyntax>(
                    _inheritance.Select(i => SyntaxFactory.SimpleBaseType(TypeGenerator.Create(i))),
                    Enumerable.Range(0, _inheritance.Count - 1).Select(_ => SyntaxFactory.Token(SyntaxKind.CommaToken))))
            : null!;

Answer 3 · 2020-07-10T09:17:30.000Z

Cool I had totally missed the built in seperator list. Thanks! It should now be fixed in the 0.17.0 version,

Answer 4 · 2020-07-11T08:48:55.000Z

slight issue. there is an extra comma at the end

Answer 5 · 2020-07-12T06:30:16.000Z

Oh damn, I did a unit test but used "contains" to assert the string and forgot to manually check so totally missed the extra comma. I will fix it later today.

Answer 6 · 2021-12-26T15:59:19.000Z

This is now fixed and will come in next release.