SieveOfEratosthenes.cs isn't the Sieve of Eratosthenes
deljohnson1 opened this issue · 3 comments
deljohnson1 commented
This is a great project and I would like to help.
I think you should have a prime class and a variety of ways to calculate primes. What is in the SieveOfEratosthenes.cs file is calculating primes by dividing the number by all primes using memoization of previously calculated primes.
siriak commented
I agree, the current implementation is incorrect. Could you make a PR to fix that?
deljohnson1 commented
Please provide me feedback for the PRs. I am new to github, so hopefully I did it correctly.
siriak commented
You haven't made a PR in this repository yet