TheAlgorithms/C-Sharp

Coverage Issue for HashTable and TimSorter Reducing Overall Code Coverage

Kalkwst opened this issue · 5 comments

Kalkwst commented

Summary
We’ve encountered a coverage issue related to two classes, HashTable and TimSorter, which is impacting the overall code coverage in our project. Despite the current PR achieving 100% coverage for the changes it introduces, these two classes are not meeting the coverage standards, which is causing a blockage due to Codecov warnings.

To Reproduce

  1. Update your branch with the latest changes from master.
  2. Run Codecov or check the coverage report.
  3. Observe that the overall coverage is lowered due to the indirect changes affecting HashTable and TimSort.

Expected behavior

  • HashTable and TimSort should have adequate unit test coverage.
  • The overall coverage metric should reflect a high coverage rate, ideally not impacted negatively by indirect changes.

Actual behavior

  • HashTable and TimSort are not covered sufficiently.
  • The overall coverage metric is reduced, leading to Codecov warnings and PR blockage.

image

siriak commented

Thank you for opening the issue, it probably happens because of randomization in tests, so coverage fluctuates a bit. I tried fixing some places where this happened, but never got to all of them. Just to make it clear, you are working on a fix, right? I'll assign you to the issue then

github-actions commented

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

ngtduc693 commented

seems this bug fixed with PR 486

siriak commented

#486 didn't change the classes in question or their tests, so I think the issue is still present