TheAlgorithms/JavaScript

Validate Url Issues

meirroth opened this issue · 9 comments

meirroth commented

Two issues found with the Validate Url algorithm:

  1. A string is considered to be valid URL if it starts with www. even though it does not have https
  • validateUrl('www.google.com') // returns true
  • validateUrl('google.com') // returns false
  1. A valid URL returns false if starts with www like:
  • validateUrl('https://wwwdomain.com') // returns false
SubhamB2003 commented

Can i try this

appgurueu commented

Can i try this

No (see the current PR).

609harsh commented

is it still open?

appgurueu commented

Yesn't? The solution might be a removal of the "algorithm" though.

trasherdk commented

Hmm. None of those test cases are valid email addresses.

validateEmail('www.google.com') // returns true ❓

  • 👀1
meirroth commented

@trasherdk Oops... It's a typo. Should say validateUrl('www.google.com').
Fixed now.

Aditya-Naresh commented

Is this issue still open?

appgurueu commented

Is this issue still open?

Yes, but bear in mind that validating URLs is much more complex than presented here:

URL syntax diagram

(from https://en.wikipedia.org/wiki/URL)

0-harshit-0 commented

hello, I would like to work on this.