TheNitesWhoSay/EUD-Ops

Undefined behaviour: this != nullptr

Opened this issue · 1 comments

AlexisTM commented

this != nullptr is undefined behaviour, always was and always will be.

The members of this cannot be called if this == nullptr.

All those checks should be removed.

(related to: https://github.com/TheNitesWhoSay/EUD-Ops/blob/master/EUD-Ops/src/MappingCore/Buffer.cpp#L50)

TheNitesWhoSay commented

At some point all of mapping core needs to be updated and that will erase all these checks https://github.com/TheNitesWhoSay/Chkdraft/tree/master/MappingCoreLib though this is not likely to be in the near future (I'm taking one additional whack at refactoring the map structure once I finish better binary&json serializers so there's no need for POD/packed structs and the indirection surrounding them)

  • 👍1