Traffic-X/MonoLSS

About Mixup3D method

Closed this issue · 7 comments

Thank you very much for your excellent work!

In the mixup3d code, I found the following code somewhat illogical:

图片2

This code, underlined in red, doesn't appear to take into account the distinction between the validation set and the training set. It is logical to take an image from self.idx_list list randomly (first take a random number whose maximum value is the length of the list, then use the list index to the corresponding value int(self.idx_list[random_num])). Here, random_num is directly used as an index to load images, and it is very likely to load images that do not belong to the training set but belong to the validation set.

Looking forward to your replies!

Thank you for your attention. For test data, this problem does not exist. What we finally uploaded only considered the completeness of the test set. For the validation set, this part needs to be changed to sampling from self.idx_list. Sorry for our negligence, we will modify this issue recently.

Thank you for your attention. For test data, this problem does not exist. What we finally uploaded only considered the completeness of the test set. For the validation set, this part needs to be changed to sampling from self.idx_list. Sorry for our negligence, we will modify this issue recently.

Thank you for your reply.

I would like to know if the above code modification will have any impact on the KITTI validation set metrics given in the paper.

If it does have an impact, would it be convenient to provide a copy of the results on the validation set after the code is correct?

This bug will have an impact on the validation set results. We are very sorry and thank you again for your help. We will update the arXiv article with new validation set results recently.

Thank you for your reply.

Thank you for your reply!Looking forward to your latest experimental data.

The arXiv paper version (https://arxiv.org/abs/2312.14474) has been updated. The new validation results are as follow. Thank you again for your attention and help.
截屏2024-05-24 下午1 27 45

The arXiv paper version (https://arxiv.org/abs/2312.14474) has been updated. The new validation results are as follow. Thank you again for your attention and help. 截屏2024-05-24 下午1 27 45

Thank you very much for your prompt reply with the new experimental data.

Could this have also happened for the Waymo experiments?