TryKickoff/kickoff

Should round up the value of the typography scale values in variables by using ceil

Closed this issue · 4 comments

The values produced by the modular scale for type should be rounded up so that the pixel equivalents are whole numbers, rather than to 3 or 4 dp as some of them are calculated. Makes the compiled CSS much more standard.

https://github.com/tmwagency/kickoff/blob/master/scss/_variables.scss#L30

I have never found this to be an issue before but I think it is a good idea. The font-sizes are generated using our modular scale function so we'd just need to tweak that to get the desired output.

I think we'd just need to change this line from:

@return $value;

to

@return ceil($value);

See SassScript docs: http://sass-lang.com/documentation/Sass/Script/Functions.html#ceil-instance_method

@ashleynolan I tried a quick test for this, see it at http://quick.as/vmr4cq8yw & let me know if you think it is acceptable.

Looks good to me :)

Closing as fixed from previous commit