Move error pages into their own folder
Closed this issue · 0 comments
Issue
There error pages (400.shtml, 401.shtml, 404.shtml, etc.) were not originally pushed onto GitHub. Recently I adjusted our .gitignore file so that I could push them onto GitHub and start working with them. But first thing's first, It doesn't seem very appealing that our error pages are just sprawled out in our root directory.
- Please move all the error pages into a folder named
error
placed within the/views
folder. - Please adjust the .htaccess file to configure the paths for these error pages. There should already be an example of how the 404.shtml page was routed for 404 errors. Make one of those for all the error pages.
Notes
This section won't always be here, but I'm including it to ease you into this ticketing process.
0. Move this ticket into the In Progress pipeline.
- Make sure you're on your
master
branch and rungit pull origin master
to make sure your master branch is synced up. - Run
git checkout -b feature/[ticket number]-your-branch name
(where ticket number is the number corresponding to this GitHub issue, and the branch name is of your choice. This is just a pretty cool naming convention that we use at work. For example, your branch name might look something likefeature/17-make-error-pages
. - Make all the necessary changes.
- Commit all your changes and push onto your branch on GitHub.
- Make a pull request from this branch over to Master.
- Move this ticket into the Review/QA pipeline.
Zenhub is a Chrome extension that attaches "boards" onto GitHub repo's. It works just like Trello, but is well integrated with GitHub because all the cards on it are GitHub issues, and it's really easy to view and move around your tickets. It's also really neat that everything is on GitHub and you don't need to visit some other site like Trello to view all your tasks. Here's a screenshot of what it looks like.
https://gyazo.com/ae1642e3070f7e7be7f3b529a86d0be3
However, if you don't want to use ZenHub, GitHub actually has "boards" built-in. It's under the "Projects" tab on this repo, and it works just slightly less better than Zenhub but enough to get by. I'll be trying to keep that updated as well in case anyone prefers to use that over Zenhub (but zenhub is pretty cool).
If you don't like any of the above task management tools, you can work directly off the ticket itself. All tickets are GitHub issues, so you can visit the "Issues" tab on this repo to see all the issues, and your tickets will be amongst them.