log2() is instrict within msvc
KottV opened this issue · 4 comments
KottV commented
Hi,
when I compile using MS Visual Studio 2022 I got this error:
Error C2169 'log2': intrinsic function, cannot be defined
in
\Vaporizer2\VASTvaporizer\Source\Engine\Utils\VASTSynthfunctions.h 991
looks like it tries to override build-in function
?VASTDynamics commented
I have commented it out. It should simply be replaced with std::log2 I believe.
Von: Konstantin Voinov ***@***.***>
Gesendet: Montag, 16. Oktober 2023 07:20
An: VASTDynamics/Vaporizer2 ***@***.***>
Cc: Subscribed ***@***.***>
Betreff: [VASTDynamics/Vaporizer2] log2() is instrict within msvc (Issue #20)
Hi,
when I compile using MS Visual Studio 2022 I got this error:
Error C2169 'log2': intrinsic function, cannot be defined
in
\Vaporizer2\VASTvaporizer\Source\Engine\Utils\VASTSynthfunctions.h 991
looks like it tries to override build-in function https://github.com/VASTDynamics/Vaporizer2/blob/e224cf890e3a411325ddf42793fc81cfb839dab4/VASTvaporizer/Source/Engine/Utils/VASTSynthfunctions.h#L991?
—
Reply to this email directly, view it on GitHub <#20> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRQQG4KKCDAH2672ORRETDX7S7YHAVCNFSM6AAAAAA6BS3J5WVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DIMZYGYYDMNY> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/AIRQQGZI7SDEPYWAHSVQDELX7S7YHA5CNFSM6AAAAAA6BS3J5WWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHHZH2CM.gif> Message ID: ***@***.*** ***@***.***> >
VASTDynamics commented
Another thing. Since yesterday somehow when trying to build a VST3 per Projucer/VS2019 it builds a .dll instead of a .vst3. Strange. Do you have an idea where this comes from? Never had that before.
Von: Konstantin Voinov ***@***.***>
Gesendet: Montag, 16. Oktober 2023 07:20
An: VASTDynamics/Vaporizer2 ***@***.***>
Cc: Subscribed ***@***.***>
Betreff: [VASTDynamics/Vaporizer2] log2() is instrict within msvc (Issue #20)
Hi,
when I compile using MS Visual Studio 2022 I got this error:
Error C2169 'log2': intrinsic function, cannot be defined
in
\Vaporizer2\VASTvaporizer\Source\Engine\Utils\VASTSynthfunctions.h 991
looks like it tries to override build-in function https://github.com/VASTDynamics/Vaporizer2/blob/e224cf890e3a411325ddf42793fc81cfb839dab4/VASTvaporizer/Source/Engine/Utils/VASTSynthfunctions.h#L991?
—
Reply to this email directly, view it on GitHub <#20> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRQQG4KKCDAH2672ORRETDX7S7YHAVCNFSM6AAAAAA6BS3J5WVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DIMZYGYYDMNY> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/AIRQQGZI7SDEPYWAHSVQDELX7S7YHA5CNFSM6AAAAAA6BS3J5WWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHHZH2CM.gif> Message ID: ***@***.*** ***@***.***> >
KottV commented
It's a correct behavior since JUCE 7.0.6 https://github.com/juce-framework/JUCE/blob/develop/BREAKING_CHANGES.md
Projucer-generated MSVC projects now build VST3s as bundles, rather than as single DLL files.
Possible Issues
Build workflows that expect the VST3 to be a single DLL may break.
Workaround
Any post-build scripts that expect to copy or move the built VST3 should be updated so that the entire bundle directory is copied/moved. The DLL itself can still be located and extracted from within the generated bundle if necessary.
Rationale
Distributing VST3s as single files was deprecated in VST3 v3.6.10. JUCE's CMake scripts already produce VST3s as bundles, so this change increases consistency between the two build systems.
KottV commented
I have commented it out. It should simply be replaced with std::log2 I believe.
easy