VEuPathDB/EdaDataService

standalone map floating boxplot `evilMode` deprecation needs fixing

Closed this issue · 3 comments

I looked at barplot which is passing noVariables to the evilMode argument but boxplot is passing false which is causing a 500

Error in veupathUtils::matchArg(evilMode) : 
'arg' should be one of “noVariables”, “allVariables”, “strataVariables”

https://github.com/VEuPathDB/EdaDataService/blob/master/src/main/java/org/veupathdb/service/eda/ds/plugin/standalonemap/FloatingBoxplotPlugin.java#L126-L136

Should probably use the same approach as barplot?

We should look at the other endpoints too, in case the same thing is there.

Is the plan to always hardcode the missingness option? Do we want to listen to what the client has to say, or no just always pass "noVariables"? Do we expect to incorporate missingness in the near term at all?

If indeed the data service should always hard code the missingness argument, please see the linked PR

i wrote it in mostly bc i dont yet know what missingness will actually look like in the map.. i suspect no matter what we do here we might see an api change later so i figured why bother.