Velocet/iown-homecontrol

Bitrate and freqdev should be in kbps and kHz

leobel96 opened this issue · 4 comments

leobel96 commented

From

iown-homecontrol/src/IoHome.cpp

Line 26 in 95778c3

io_home_fskrate.fsk.bitRate = 38400;

and

iown-homecontrol/src/IoHome.cpp

Line 27 in 95778c3

io_home_fskrate.fsk.freqDev = 19200;

the values should be 38.4 and 19.2

Velocet commented

Why use a higher unit which needs floats instead of this simple define?

leobel96 commented

Define? I'm just saying that, from the Radiolib documentation:

struct FSKRate_t {
  /*! \brief FSK bit rate in kbps */
  float bitRate;
  
  /*! \brief FS frequency deviation in kHz*/
  float freqDev;
};

So, considering that you want 38.4kbps and 19.2kHz the values should be 38.4 and 19.2

  • 👍1
Velocet commented

You are totally right! Shame on me! Will be fixed with the next bigger code commit.

Thank you for finding and correcting me 👍🏻

leobel96 commented

No problem :)

  • 👍1