Small problem with MSG_IF and MSG_OI formatting (and solution)

Question

Small problem with MSG_IF and MSG_OI formatting (and solution)

Closed this issue 3 years ago · 3 comments

First of all thank you for the great library, it was exactly what I was looking for and is working well.

There is a problem with the IF and OI message formatting however if the radioStatus.MDA or radioStatus.MDB mode is greater than 9. This is because it should be represented as a single hexadecimal character but it actually gets written as two decimal characters as a result of the %1u in the format string. The solution is to change %1u to %1X in lines 504 and 510 in FT891_CAT.cpp.

Answer 1 · 2021-06-01T14:53:38.000Z

Thanks Rick! not sure how I screwed that up! You also need to change it in line 559 where it responds to the “MD” message. I’ll fix it on GitHub shortly. John From: Rick MacDonald ***@***.*** Sent: Tuesday, June 01, 2021 10:35 AM To: WA2FZW/An-FT-891-CAT-Control-Emulator-Library-by-WA2FZW Cc: Subscribed Subject: [WA2FZW/An-FT-891-CAT-Control-Emulator-Library-by-WA2FZW] Small problem with MSG_IF and MSG_OI formatting (and solution) (#3) First of all thank you for the great library, it was exactly what I was looking for and is working well. There is a problem with the IF and OI message formatting however if the radioStatus.MDA or radioStatus.MDB mode is greater than 9. This is because it should be represented as a single hexadecimal character but it actually gets written as two decimal characters as a result of the %1u in the format string. The solution is to change %1u to %1X in lines 504 and 510 in FT891_CAT.cpp. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG2ZI27VUJTKIVCCQ4OFZI3TQTVZZANCNFSM454ZZWFA> . <https://github.com/notifications/beacon/AG2ZI2446MSHK66ZYAKK2BDTQTVZZA5CNFSM454ZZWFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4NREPXOA.gif>

…

-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Answer 2 · 2021-06-01T16:16:40.000Z

I'm glad to be of assistance John and sorry I missed that other one.

Cheers!

Rick

Answer 3 · 2021-06-01T16:19:08.000Z

I found that one while making sure the mode was being handled correctly when it was being set. JP

…

On June 1, 2021 12:16:58 PM Rick MacDonald ***@***.***> wrote: I'm glad to be of assistance John and sorry I missed that other one. Cheers! Rick — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.