WalletConnect/WalletConnectUnity

WalletConnect.Instance.RequestAsync method doesn't complete when there is no internet connection

Closed this issue · 3 comments

astasovsky commented

Describe the bug
WalletConnect.Instance.RequestAsync method doesn't complete or throws timeout exception when there is no internet connection

To Reproduce
Steps to reproduce the behavior:

  1. Open app
  2. Connect crypto wallet
  3. Turn off the Internet
  4. Click "personal_sign" button
  5. See that nothing happens (async operation is not completed or TimeoutException is not thrown)
  6. Turn on the Internet
  7. See that async operation is not completed or TimeoutException is not thrown

Expected behavior
WalletConnect.Instance.RequestAsync method should complete or throw TimeoutException

Environment

  • OS: macOS 14.3.1
  • Unity version 2021.3.23f1
  • Package name and version WalletConnectUnity Modal v1.1.2

Is this happening in Unity Editor or on a player like Android, iOS, Windows?
This is happening in Unity Editor and on Android. It hasn't been tested in iOS and Widows.

Wallets used for testing
Metamask Android, Trust Wallet Android, SafePal Android

skibitsky commented

Hey @astasovsky,

Thanks for opening the issue! PR #209 should resolve this, and I'll be releasing a new package next week that includes these changes. This update should also address issue #201.

Additionally, I want to thank you for following the issue template and providing all the necessary details. It’s a pleasure to work with :)

  • 👍1
astasovsky commented

Hey @skibitsky! Thank you being so quick to respond, fix bugs and release new versions!

  • 🎉1
skibitsky commented

Fixed in WalletConnectUnity Modal v1.1.3