hitable.rs looks code-smelly
Opened this issue · 0 comments
Walther commented
hitable.rs looks code-smelly.
- lots of repetition
- hitablelist, bvhnode, etc feel like they have weird relationships
- how should the construction really be done at scene load time
- how should the ownership model be
- in a PR long time ago, moved away from dyn traits to manual enums. this has made a lot of the codebase ugly. original justification was potential performance gains. does this really hold?
- is hitrecord good? should the material be a reference or should it be owned? something else? this also propagates around the codebase a lot, so changes here need to happen in a lot of places