WebAssembly/stringref

New instruction `string.from_code_point`

Liedtke opened this issue · 7 comments

Liedtke commented

Following up on #5 (comment) we decided to implement string.from_code_point for performance evaluations in V8 (see also #58):

  • string.from_code_point(codepoint: i32) -> ref string, opcode 0xfba9
  • returns a string consisting of the provided codepoint
  • the instruction traps if the argument is not a valid unicode codepoint
gkdn commented

Shouldn't this be returning ref string instead?
@Liedtke @jakobkummerow

gkdn commented

BTW, I think also binaryen mismatches Chrome here and assumes the instruction returns ref string which results in code rejected by V8. Adding @kripken to verify.

  • 👍1
Liedtke commented

@gkdn Yeah, the returned value is never null. I'll adapt the return type in v8 and in my comment above.

  • 👍1
MaxGraey commented

What should happen for invalid code points? Like 0x110000 and above. In JavaScript this leads to an exception. At least for String.fromCodePoint

Liedtke commented

@MaxGraey The instruction traps for invalid codepoints.

  • 👍1
gkdn commented

@Liedtke do you have link to the dashboard to track the release? or if you know dev-channel version to get the fix that would work as well.