Support more feature.
sonder-joker opened this issue · 5 comments
I have tried to port wasi-crypto to RustCrypto/traits.
Compare with RustCrypto target wasm32-wasi, it have Ssgnificant speed increase.
However, I meet some feature we don't have. I will record them here.
Support symmetric_state_reset.
Instead of recreate a new state, just reset it consider more efficient. May a optional feature.
Support symmetric_state_copy.
A deep copy of state return a new handle. I believe it will be easy for people want to copy.
Besides, RustCrypto/Traits require state can copy.
My preliminary implementation here.
After support RustCrypto/traits, we can also use RustCrypto test for #52.
I'm not too fan of symmetric_state_reset.
Some ciphers and keyed hash functions using a rolling state have a really useful property: if a state is leaked, the initial state or the key cannot be recovered.
Supporting a reset operation defeats this, and requiers keeping a copy of the secret key or the initial state forever. Even if reset is never called.
I'm not too fan of
symmetric_state_reset.Some ciphers and keyed hash functions using a rolling state have a really useful property: if a state is leaked, the initial state or the key cannot be recovered.
Supporting a
resetoperation defeats this, and requiers keeping a copy of the secret key or the initial state forever. Even ifresetis never called.
Thanks for your advice. Supporting reset is inappropriate.