Yarroudh/segment-lidar

specify that CSF should be installed

hugoledoux opened this issue · 7 comments

hugoledoux commented

to run the example one needs CSF, but you don't specify it as a requirement:

this seems to be the good one? pip install cloth-simulation-filter?

Yarroudh commented

Hello @hugoledoux,

Thanks for your interest in segment-lidar.

Did you install the package from source? CSF is directly installed on your environment when installing segment-lidar, either from PyPI or from source. In the setup.py, the package is installed from source (line 15).

hugoledoux commented

No I used pip, and why is it not in requirements.txt?

Yarroudh commented

I think there is a bug in the last version 0.1.8 that was published on PyPI. Thanks for mentioning this issue.
You can always install the package from source to avoid this problem by running:

git clone https://github.com/Yarroudh/segment-lidar
cd segment-lidar
python setup.py install

Or, you can install CSF on you environment:

pip install git+https://github.com/jianboqi/CSF.git

This should resolve the error for now. I will publish a new version on PyPI soon.

Yarroudh commented

Unfortunately, PyPI does not support external dependencies anymore, and CSF package should now be installed manually before installing segment-lidar from PyPI. If you opt for installing the package from source, I just added CSF to requirements.txt.

Yarroudh commented

Oups, I litterally missed that package on PyPI as I was looking for CSF. I thought the package could only be installed from source, I did not pay attention to their metadata. This solves the issue. Thanks for the assistance on that.

Yarroudh commented

Closing this issue for now, which I consider solved. The package is up to date in PyPI (v0.1.8.5).
Feel free to re-open it if the error re-appear in upcoming versions.