Zahner-elektrik/zahner_potentiostat

bug: dependencies not specified

Closed this issue · 3 comments

The module zahner_potentiostat.scpi_control.searcher depends on the package pyserial:

from serial.serialwin32 import Serial
import serial.tools.list_ports

In fact, none of the dependencies are specified in the package configuration (currently setup.py, should be replaced by pyproject.toml, see #2).

matplotlib appears to be another dependency of the package but is also not specified.

I just checked the import statements:

import statements
$ git grep -h 'import' | grep -v 'zahner_potentiostat' | sort | uniq 
from abc import ABCMeta, abstractmethod
from builtins import isinstance
from .datareceiver import DataReceiver
from .datareceiver import TrackTypes
from datetime import datetime
from .dcplot import DCPlot
from enum import Enum
from .error import ZahnerConnectionError
from .error import ZahnerDataProtocolError
from .error import ZahnerSCPIError
from .HUDDSCOL import *
from matplotlib.ticker import EngFormatter
from .NYCCCOL import *
from .serial_interface import CommandType,DEBUG
from serial.serialutil import SerialException
from serial.serialwin32 import Serial
from threading import Thread, Semaphore
    """ General important information for the control of the devices with this class.
        Here the sign of the ramp is important and indicates the direction of the ramp.
import copy
import glob
import matplotlib
import matplotlib.pyplot as plt
import multiprocessing
import numpy
import numpy as np
import queue
import re
import serial
import serial.tools.list_ports
import setuptools
import struct
import sys
import threading
import time
        There is also an example to import data from an drive cycle.

So the dependencies are probably:

  • matplotlib
  • pyserial
  • numpy

I will add them to the setup.py now...

I opened a PR (#10). I am more of a GitLab user than a GitHub user so I probably did sth. wrong why the PR does not show up here, so mention it directly.