ZieIony/Carbon

Check ProGuard rules and update installation guide for 0.16.0.1 and master's head.

koral-- opened this issue · 1 comments

Data binding enabling has been removed from wiki:
https://github.com/ZieIony/Carbon/wiki/Installation/_compare/91c996c21d10d6a392ececfe7f27f94b50d2f699...533c5ddd5f0f04b11d91228ca8e8ac7f00fbcc6d

However, related proguard rules are still listed:

-dontwarn android.databinding.**
-keep class android.databinding.** { *; }

Is it somehow intended? Or they are redundant?
BTW why don't embed consumer proguard rules?

I simply forgot that these rules were there. I rarely build my side projects in release versions, so I don't pay too much attention to that, unless someone points that out. Data binding was the only thing that didn't work in the history of Carbon because of ProGuard.

I updated these instructions to be up-to-date with what's now on master branch. Carbon currently uses view binding internally, so data binding setup is not needed with that version. I didn't check if this generator needs ProGuard rules though.