Znerox/wifimap

javascript errors

Opened this issue · 1 comments

e1z0 commented

Hi,

I've got javascript console errors when trying to load map, map loads but without any point data, the database is already filled, api key is set correctly. Error looks like:

Uncaught TypeError: xml is null
    loadMap https://wifi.lan/js/index.js:124
    onreadystatechange https://wifi.lan/js/index.js:201
    downloadUrl https://wifi.lan/js/index.js:198
    loadMap https://wifi.lan/js/index.js:122
    loadSettings https://wifi.lan/js/settings.js:98
    loadMapThemes https://wifi.lan/js/mapthemes.js:614
    setVariables https://wifi.lan/js/index.js:23
    onload https://wifi.lan/:1

Update: already fixed it, there was no global settings for mysql database/password etc, i've made that it reads them from environment variables, now working \o/

Fixed the code using Null coalescing operators if environment variables are not available then use your default values, i can make pull request if you want and merge the changes.

So you're building your own docker image based on this code? I have not really considered that use case, so the code in this repo does not look for environment variables (the code used to build the docker image is slightly changed).

This wiki article explains what files needs to be changed, as I see you've already figured out.

I'll look into the suggested changes.