abbaye/WpfHexEditorControl

Read only label is not affected by status bar visibility

Filipsi opened this issue · 1 comments

Filipsi commented

Describe the bug
Label indicating that editor is in "read only" mode is not affected by status bar visibility and creates empty space if shown.

To Reproduce

  1. Set StatusBarVisibility property to "Collapsed"
  2. Set ReadOnlyMode property to "True"

Expected behavior
Currently, the "read only" label is not part of the status bar.
In my opinion, this is incorrect since read only mode is a "status" of the editor.
It would be helpful to move it to the status bar, since it would allow it to be hidden.
As a side effect, it would also probably resolve positioning issues simar to ones described in issue #74.

Alternatively, if it's not possible to change editor layout, it would be helpful to at last have property to control it's visibility.

Screenshots
Read only mode disabled with status bar collapsed
example1

Read only mode enabled with status bar collapsed
example2

Desktop:

  • OS: Windows 10
  • Platform: .NET Core 3.1
abbaye commented

Oupssi will correct this 😅