Support isolate view options
Closed this issue · 15 comments
Problem
Currently there's no way to parse and/or apply any Isolate View options to capture only a subset of what is in the scene.
Solution
Add the options related to the modelEditor in the viewport options or amongst a new Options dictionary. And also implement the "parsing" of the settings from a view/panel.
Are you referring to this option?
isolate (list): List of nodes to isolate upon capturing
And that it should be included in the results of capture.parse_view(), and applied via capture.apply_view()?
Ha, yes. Exactly that option actually!
I remembered seeing it in the docstring so quickly glanced over it, but apparently missed it this afternoon, twice. Sorry about that and thanks fo pointing me to it.
Aside from that particular option I'm in doubt of having it parse with the parse_view and apply_view because it's so related to a specific state of the scene (the nodes actually existing), as such less stateless than the other options. For example it wouldn't be as interesting in a preset of sorts.
What are your thoughts/ideas?
For example it wouldn't be as interesting in a preset of sorts.
That's a good point. With that, I think we should leave it out.
I was thinking maybe just adding an example to the readme of how to retrieve the currently active objects and pass it to capture() and leave it at that.
That way we've handled the use case for those who are looking for it.
Yeah, that could work. Will you have a look at that?
Sure will. Probably tomorrow!
Thanks Roy!
An example is added in BigRoy@611a08c
Notice that you'll need the previous commit BigRoy@8f9ba4a as well to have the parse_active_panel() function in capture. This simplified things a lot which I felt was good.
What do you think?
Looks good. Could you make it a PR? Then I can comment on individual lines.
The original proposal here hasn't been implemented, yet it has been documented as was proposed in the discussion.
This documentation was implemented in the README with PR #62
The original proposal here hasn't been implemented
Hadn't it already been implemented? Or which proposal are you referring to?
Hadn't it already been implemented?
Ah, actually you're correct. Derp. It is actually implemented, except for getting the isolated view nodes with one of the default parse methods.
So yes, applying isolate nodes was implemented yet parsing the currently isolated ones wasn't and still isn't. Instead the latter is documented on how to do it.
Thanks for correcting me! :)
So yes, applying isolate nodes was implemented yet parsing the currently isolated ones wasn't and still isn't.
Wait wait wait, I thought we said we didn't need the parse version of this, as it didn't make sense? From this comment.
Ah, the comment wasn't intended to describe a missing feature but to indicate the path that was eventually chosen as this particular issue was closed. So it described the end result and the reason it was closed (and thus solved).
We've decided that documenting on how to parse it manually would suffice instead of adding it to the readily available parse function as the resulting values (currently isolated nodes in a view) are very specific to a certain state of a scene that can hardly be re-applied in many scenes (node names tend to be different in different scenes). As such it's much less of a re-usable piece of information. As indeed described in that comment.
In short, what we decided on as feature documentation is in there and implemented yet it's not a parsing method as originally described at the start of this issue.
Cool!