fzf should be optional

Question

fzf should be optional

zbbfufu opened this issue 5 years ago · 3 comments

In original kubectx/kubens, fzf is optional and fuzzy searching features only activates if fzf is found on the path.
Having the same behavior in go-kubectx will ease switching to your implementation.

Answer 1 · 2020-03-02T15:28:34.000Z

@zbbfufu That's fair points. Will try with some other libraries later.

Answer 2 · 2020-03-02T18:59:58.000Z

could actually probably import fzf as a lib as well 🤔

Answer 3 · 2020-03-02T19:27:25.000Z

I was more thinking about a feature switch based on fzf availability, but including fzf in binary may be an option :) Le lun. 2 mars 2020 à 19:59, Carlos Alexandro Becker < notifications@github.com> a écrit :

…

could actually probably import fzf as a lib as well 🤔 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AACRQ7VD4ZOZMDZ6SBCIZ7DRFP625A5CNFSM4K7RX7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENQQUMQ#issuecomment-593562162>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRQ7XBTEVXOQP3NWSVLBTRFP625ANCNFSM4K7RX7LA> .