Add empty state to tables on pair request#index
Closed this issue · 10 comments
Describe the bug
Pair requests tables should have an empty state.
To Reproduce
Go to pair requests #index action
Screenshots
Hello @afogel ,
Can you please guide me where this screenshot view is available?
I can't see this after signing up.
Hey @Nagendra88688,
Thanks for expressing interest in working on this issue! So if you've cloned the repo and followed the instructions to start the server (including setting up the database and running rails db:seed), you should be able to find it by logging in and going to http://localhost:3000/pair_requests.
(See the seeds file for login credentials)
Okay
Hey @afogel - I'd love to work on this issue. Can you please assign it to me? Thanks. :)
Hey @afogel - I've submitted the PR for its fix. Would love to hear your thoughts on it. :)
Hey @afogel - I came up with the following wireframe for the empty state page. Sorry, it was my first time with the design part 😅
Please let me know what you think about it. Thanks.
Hey @chahmedejaz; thanks for updating.
Unfortunately, the CTA doesn't really make much sense since the form is above the table; also, the empty state does not take into account states on both tabs.
As a general note -- Though we're developing this project as an open source one and appreciate the effort you have put in so far, the Agency is currently drafting a new policy that will request that only individuals admitted the Agency work on these issues. While we do mark some issues as good first issues, we intend to use these to help new members onboard onto working on the app. We appreciate the work you've put in so far, but would recommend you searching to contribute on another project that has a bit more bandwidth to bring in outside contributors.
Good luck!
Sure, @afogel, no worries :)
Wishing you the best of luck. It was nice working on this project. 😄
P.S: I'm closing its PR as I beleive it's of no use now.
Looks great! Get it :)