Use default value for "Match highlight background color" instead of custom.
DenysPanchenko opened this issue · 6 comments
I use dark theme in Eclipse and customize some colors by myself. Regular eclipse consider my changes whereas Insta not.
OS: Windows 7, Eclipse Luna with MoonRise color theme
Ah yes, looks like the color is hardcoded at the moment https://github.com/ajermakovics/eclipse-instasearch/blob/master/instasearch/src/it/unibz/instasearch/ui/ResultLabelProvider.java#L61
Would be better to get the one from Eclipse. There's probably API to get it somehow...
Hi,
may I ask if this issue is going to be fixed?
BR.
I'm using the Darkest Dark theme with Eclipse Oxygen and, despite the PR referenced in #80 looking like it also fixes this issue, I'm still seeing unreadable match highlights. Looking over the code in that PR, it seems that there's a fallback to a hard-coded color (the one that I'm getting which makes the text impossible to read) if the one looked up (for search matches) isn't found. Since the looked-up color (ECLIPSE_SEARCH_UI_MATCH_HIGHLIGHT) isn't found, I'm wondering if this is the correct color to try and use here. As it is, it's not even clear to me which color I should try and modify to make things readable.
Can someone confirm that this is still broken with Eclipse Oxygen and dark themes?
Yeah. Still broken.
Yup still broken, and very annoying.
Solve in 1.5.7 !