aldebaran/qibuild

Keyword arg install_tc_packages is missing in MetaPMLBuilder::package method on master branch

Closed this issue · 2 comments

def package(self, with_breakpad=False, output=None, force=False):

Identified with unit tests on a travis build

probably forgotten when adding toolchain support

=================================== FAILURES ===================================
__________________________________ test_meta ___________________________________
[gw1] linux2 -- Python 2.7.13 /home/travis/virtualenv/python2.7.13/bin/python
qipkg_action = <conftest.QiPkgAction object at 0x2b94dbad3590>
 def test_meta(qipkg_action):
 tmpdir = qipkg_action.worktree.tmpdir
 qipkg_action.add_test_project("a_cpp")
 qipkg_action.add_test_project("d_pkg")
 meta_pkg_proj = qipkg_action.add_test_project("meta_pkg")
 meta_pml = os.path.join(meta_pkg_proj.path, "meta_pkg.mpml")
 qipkg_action("configure", meta_pml)
 qipkg_action("build", meta_pml)
> pkgs = qipkg_action("make-package", meta_pml)
/home/travis/build/cpoisson/qibuild/python/qipkg/test/test_qipkg.py:79:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/home/travis/build/cpoisson/qibuild/python/qisys/test/conftest.py:182: in __call__
 return qisys.script.run_action(module_name, args)
/home/travis/build/cpoisson/qibuild/python/qisys/script.py:125: in run_action
 return module.do(parsed_args)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
args = Namespace(backtrace=False, build_prefix=None, color='auto', config=None, force...auto', verbose=False, with_breakpad=False, with_toolchain=False, worktree=None)
 def do(args):
 """Main entry point"""
 output = args.output
 with_breakpad = args.with_breakpad
 force = args.force
 with_toolchain = args.with_toolchain
 pml_builder = qipkg.parsers.get_pml_builder(args)
> return pml_builder.package(output=output, with_breakpad=with_breakpad, force=force, install_tc_packages=with_toolchain)
E TypeError: package() got an unexpected keyword argument 'install_tc_packages'

Here's a fix
https://github.com/cpoisson/qibuild/commit/68ec23c9f202cad6901b33f1cfb30e81d49140ce

Seems to fix the problem => Build here

Nice one 👍 ✅

Should be fixed by now, @ngargaud ;)