aldeebhasan/lottie-laravel

avoid cdn

Opened this issue · 2 comments

grafst commented

Hi
Great Package, works like a charm.
I would suggest avoiding pulling in the lottie.js file via cdn.
Here are a couple of reasons why

I think best would be to use npm. that way it is also easy to upgrade.

Hi, thanks for your support, you are right, we need to find away to avoid cdn and any external resource loading.
Using npm could solve the issue, but i dont want to add another steps in order to make the package work.
i will check and do something regarding this possible enhancement

grafst commented

I respect that you don't want to add extra steps.
Maybe this can help? https://freek.dev/2333-creating-installer-commands-for-laravel-packages
Then just put the file in the package and update it every time lottie gets updated?