alexiszamanidis/vscode-git-worktrees

Crash when spaces in the name

naytun opened this issue · 5 comments

naytun commented

When I added a new worktree with spaces in the name, it crashed.

alexiszamanidis commented

Hi @naytun,

It seems git doesn't allow you to create a branch with spaces.

image

Since the name of the worktree and branch is the same, I think it would be better not to use spaces and maintain consistency.

I don't want to be hostile or reject you. I just expressed my thoughts.

Please let me know what you think.

naytun commented

Fist of all, I like the simplicity and easy of use of the extension. I understand the cause of this issue. But, as for a new user of this extension it would be better to mentioned that space issue somewhere in the extension (or) warn the user. My suggestion only. Thank you for the reply.

alexiszamanidis commented

I'm glad you liked it.

This is a great idea. I will definitely mention it in the documentation.

Thank you for your contribution!

jonz94 commented

Hi,
I also encounter the similar issue when I name the new branch should-work?.

It turns out that there are tons of rules about git branch name format. (Which characters are illegal within a branch name?)

Fortunately, we can use git's built-in check-ref-format command to validate branch name format.

I open a PR to add this feature, hope this will make the experience better 😄

  • ❤️1
  • 🚀1
alexiszamanidis commented

Hi @jonz94,

You are back with another excellent contribution.

I tested your validation, and it works great.

Thank you, once again, for your time and contribution.

  • 😄1
  • ❤️1