Add search functionality

Question

Add search functionality

alexweininger opened this issue 5 years ago · 15 comments

Awesome!

Answer 1 · 2019-10-05T17:45:25.000Z

Hey @alexweininger 👋🏻
I'd like to work on this but I'm running into this issue (step 4 of Getting Started)

It appears to be looking for a manifest file that doesn't exist. This is the first chrome extension I've worked on so forgive me if I'm overlooking something.

Answer 2 · 2019-10-05T20:43:44.000Z

Make sure to select the dist/ directory. This directory holds the output of the src/ and the things Chrome needs to bundle the extension. (this is where the manifest.json file is located as well).

Hope this helps!

Answer 3 · 2019-10-05T21:05:17.000Z

@alexweininger Ah, you have to make sure to run yarn/npm watch first. Might want to add that to the readme even if it's implied. You mind assigning me this search functionality task?

Answer 4 · 2019-10-05T23:29:43.000Z

Assigned the task to you, let me know if you have any other questions. Thanks!

Answer 5 · 2019-10-06T00:12:45.000Z

@alexweininger Hey man, can you point me in the right direction for enabling my chrome debugger to actually detect console statements or debuggers I place in the code for this extension. It seems like I can't get anything to trigger or log. So I'm stuck here!

Answer 6 · 2019-10-06T00:14:45.000Z

Ya I remember this being a little tricky. Let me see what I can find out for you. What happens if you Right click -> inspect element within the chrome extension popup? I believe this is where the console output should be. (Rather than the debugger attached to the browser window itself)

Answer 7 · 2019-10-06T00:32:23.000Z

Ah I see! It's actually "inspect pop up" but thanks for the direction:

Answer 8 · 2019-10-06T00:35:19.000Z

@alexweininger Glad I can be the source of all your hacktoberfest treats 😉🎃

Answer 9 · 2019-10-06T01:27:28.000Z

@alexweininger maybe we can find a way to screen share or something in the next couple of days for you to walk me through this debugging process because it seems pretty hit or miss for me right now and it's hard for me to figure out what's going on. Especially being so used to a react environment 😛 I like the vanilla js aspect though.

Answer 10 · 2019-10-06T01:28:25.000Z

Is it typescript that's giving you trouble?

Answer 11 · 2019-10-06T01:36:36.000Z

No I love typescript. It’s really the debugging process. I set breakpoints and they aren’t hit. I set console logs and they don’t log. If I manually inspect the chrome extension specifically I can see them sometimes after the fact but not in real time and the window randomly goes away. It’s just an environment I’m not familiar with I guess. I write React with typescript on a daily basis but like I mentioned initially I’ve never messed with chrome extensions so I guess I’m a bit out of my element.

…

On Sat, Oct 5, 2019 at 9:28 PM Alex Weininger ***@***.***> wrote: Is it typescript that's giving you trouble? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#59?email_source=notifications&email_token=AIVCT27536LUXLRW67WOKBTQNE5LTA5CNFSM4I5JNUX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAN7L7I#issuecomment-538703357>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIVCT22RAF2QVF5MJZKGGHLQNE5LTANCNFSM4I5JNUXQ> .

Answer 12 · 2019-10-06T01:44:25.000Z

I've dealt with similar issues before.

I found answers in this post to be helpful.

One of the answers shows how to do this:

find the ID: for the recent pdf extension in chrome://chrome/extensions/
You can then load your popup in a regular window by
chrome-extension://id_of_your_application/index.html

Also you can reload the debugger and it will reload the popup, and then hit the breakpoints without closing the debugger. Just press Ctrl + R while focusing on the debugger window.

The reason why the breakpoints are not hitting is that the popup loads and runs the scrips before you open the popup. Kinda annoying but you just need to have the debugger attached before you reload the popup.

Answer 13 · 2019-10-06T01:47:32.000Z

This is the ultimately the best solution (from the post you linked):

…

On Sat, Oct 5, 2019 at 9:44 PM Alex Weininger ***@***.***> wrote: I've dealt with similar issues before. I found answers in this post <https://stackoverflow.com/questions/5039875/debug-popup-html-of-a-chrome-extension> to be helpful. One of the answers shows how to do this: 1. find the ID: for the recent pdf extension in chrome://chrome/extensions/ 2. You can then load your popup in a regular window by chrome-extension://id_of_your_application/index.html https://stackoverflow.com/questions/5039875/debug-popup-html-of-a-chrome-extension — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#59?email_source=notifications&email_token=AIVCT22TDM7E74LVEXIZ77LQNE7HTA5CNFSM4I5JNUX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAN7RYQ#issuecomment-538704098>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIVCT267CWY6TO6JMJSBMEDQNE7HTANCNFSM4I5JNUXQ> .

Answer 14 · 2019-12-20T07:08:35.000Z

Closed in #109