amzn/zeek-plugin-bacnet

NPCI bit-combination 0x2C should be supported

duffy-ocraven opened this issue · 0 comments

The conditionals

            else if (control == 0x08 ||
                control == 0x0c ||
                control == 0x20 ||
                control == 0x24 ||
                control == 0x28
                ) {

and

                if (control == 0x28) {

and

                if (control == 0x20 ||
                    control == 0x24 ||
                    control == 0x28) {

are missing the bit-combination 0x2C. Bit 2 is merely the data_expecting_reply parameter. The code can generally parse all possible network layer messages irrespective of bit2.