White horizontal line in middle of the tag

Question

White horizontal line in middle of the tag

wimbledon opened this issue 11 years ago · 20 comments

In iPhone 5, XCode 5.1.1 and iOS 7.1.1, there are White horizontal line in middle of the tag as per the image below:

👍

Answer 1 · 2014-05-09T10:23:36.000Z

Hi @wimbledon
Can you provide more info? The demo project seems to run fine, are you using any custom value in the tag appearance? Can you reproduce the issue in the demo project?

Answer 2 · 2014-05-10T05:29:30.000Z

The way I'm using the AMTagListView is putting it into a UITableViewCell's contentView. I tried to do this in the demo project to repro the issue, but the problem did not repro.

Here is my code for the tag cell:
https://gist.github.com/wimbledon/8878e53bde892f9c6d3d

Answer 3 · 2014-05-14T21:18:48.000Z

Can you checkout the latest commit? I have a feeling that your problem might be fixed by this pull request #9

Answer 4 · 2014-05-25T14:13:55.000Z

I have checked with latest commit, but the issue still persist.... :(

Answer 5 · 2014-05-28T08:11:50.000Z

Ok, got it. It happens when the height is not an integer.
I'll fix it right away.

Answer 6 · 2014-05-28T08:19:31.000Z

Checkout commit b6924e2 for the fix

Answer 7 · 2014-05-29T15:43:45.000Z

@andreamazz I tried b6924e2 for the fix, but it did not resolve the issue for me...
What height needed to be integer?

Answer 8 · 2014-05-30T08:10:22.000Z

Uhm, weird. I'm referring to the tag's height (that gets computed by the library itself).
I was able to reproduce your issue by forcing a non integer height (something like 20.5f), and now i round it up in the library.

Answer 9 · 2014-05-30T08:17:06.000Z

You mean the self.tagsList.contentSize.height?

Answer 10 · 2014-05-30T08:19:20.000Z

I mean this height https://github.com/andreamazz/AMTagListView/blob/master/AMTagListView/AMTagListView.m#L73

Answer 11 · 2014-05-30T10:38:31.000Z

Hmm. This is driving me crazy!

Answer 12 · 2014-05-30T10:44:39.000Z

could the problem be in AMTagView's drawRect function where /2 should be replaced by /2.0 to make sure there is no rounding issue?

Answer 13 · 2014-06-01T10:42:46.000Z

I made another attempt in commit 22bdb7b.
Let me know

Answer 14 · 2014-06-01T11:02:11.000Z

Thanks. The new commit did not change anything.

However, I noticed that the commit b6924e2 did have some improvement. In the sense that for some AMTagViewLists, there was no white line. However, for the other cases, there was thinner white line.

David

Answer 15 · 2014-06-01T11:03:21.000Z

Can you nslog the tag's height received by addTag:?

Answer 16 · 2014-06-01T11:08:58.000Z

I nslogged the tag's height, it's always 32.000000 even for the cases with no white line, thin white line and thick white line.

Answer 17 · 2014-06-02T10:57:34.000Z

I see. I have to try and draw the tag with just one bezier path to avoid this. I'll keep you posted.

Answer 18 · 2014-06-02T14:56:46.000Z

Ok, I'm feeling confident, checkout commit 4db36ed.
I trashed the code that was creating the hole in the tag as a mask. That should do the trick

Answer 19 · 2014-06-02T15:17:42.000Z

Yes! It worked!!! Thank you!