andreasgerstmayr/fava-dashboards

fava_dashboards.templates is absent from setuptools' packages configuration

AlphaJack opened this issue · 3 comments

* Getting build dependencies for wheel...
* Building wheel...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/fava_dashboards
copying fava_dashboards/__init__.py -> build/lib/fava_dashboards
running egg_info
creating fava_dashboards.egg-info
writing fava_dashboards.egg-info/PKG-INFO
writing dependency_links to fava_dashboards.egg-info/dependency_links.txt
writing requirements to fava_dashboards.egg-info/requires.txt
writing top-level names to fava_dashboards.egg-info/top_level.txt
writing manifest file 'fava_dashboards.egg-info/SOURCES.txt'
adding license file 'LICENSE.md'
writing manifest file 'fava_dashboards.egg-info/SOURCES.txt'
/usr/lib/python3.11/site-packages/setuptools/command/build_py.py:201: _Warning: Package 'fava_dashboards.templates' is absent from the `packages` configuration.
!!

        ********************************************************************************
        ############################
        # Package would be ignored #
        ############################
        Python recognizes 'fava_dashboards.templates' as an importable package[^1],
        but it is absent from setuptools' `packages` configuration.

        This leads to an ambiguous overall configuration. If you want to distribute this
        package, please make sure that 'fava_dashboards.templates' is explicitly added
        to the `packages` configuration field.

        Alternatively, you can also rely on setuptools' discovery methods
        (for example by using `find_namespace_packages(...)`/`find_namespace:`
        instead of `find_packages(...)`/`find:`).

        You can read more about "package discovery" on setuptools documentation page:

        - https://setuptools.pypa.io/en/latest/userguide/package_discovery.html

        If you don't want 'fava_dashboards.templates' to be distributed and are
        already explicitly excluding 'fava_dashboards.templates' via
        `find_namespace_packages(...)/find_namespace` or `find_packages(...)/find`,
        you can try to use `exclude_package_data`, or `include-package-data=False` in
        combination with a more fine grained `package-data` configuration.

        You can read more about "package data files" on setuptools documentation page:

        - https://setuptools.pypa.io/en/latest/userguide/datafiles.html


        [^1]: For Python, any directory (with suitable naming) can be imported,
              even if it does not contain any `.py` files.
              On the other hand, currently there is no concept of package data
              directory, all directories are treated like packages.
        ********************************************************************************

!!
  check.warn(importable)
copying fava_dashboards/FavaDashboards.js -> build/lib/fava_dashboards
[...]

@AlphaJack could you check if #19 solves this issue?

Yes it does!

Thanks for checking!