Compile error when WEBSOCKETSSL is switched on (missing changed IdSSLOpenSSL file)

[tijmenvangulik]

First thanks for this cool websockets library. Good code, Great work!

One problem: When I switch on the WEBSOCKETSSL compiler directive I get the error
[dcc32 Error] IdServerIOHandlerWebsocket.pas(29): E2137 Method 'CreateOpenSSLSocket' not found in base class

The problem is that the due to the following commit:
cdffdd2

It the comment learns me that a change in the IdSSLOpenSSL is needed but the changed IdSSLOpenSSL is not commited.

Can you please commit the changed IdSSLOpenSSL file?

Thanks

Tijmen

[andremussche]

Which delphi and Indy version do you use? At least for XE10.1 it uses the new "GetIOHandlerSelf" function: {$if CompilerVersion >= 31} //XE10 function GetIOHandlerSelf: TIdSSLIOHandlerSocketOpenSSL; {$else} function CreateOpenSSLSocket:TIdSSLIOHandlerSocketOpenSSL; override; {$endif} 2016-12-02 11:47 GMT+01:00 Tijmen van Gulik <notifications@github.com>:

…

First thanks for this cool websockets library. Good code, Great work! One problem: When I switch on the WEBSOCKETSSL compiler directive I get the error [dcc32 Error] IdServerIOHandlerWebsocket.pas(29): E2137 Method 'CreateOpenSSLSocket' not found in base class The problem is that the due to the following commit: cdffdd2 <cdffdd2> It the comment learns me that a change in the IdSSLOpenSSL is needed but the changed IdSSLOpenSSL is not commited. Can you please commit the changed IdSSLOpenSSL file? Thanks Tijmen — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#16>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC5IjtcyytiI8VSAV5wJa-yAm4gQUhs7ks5rD_cygaJpZM4LCbCh> .

[tijmenvangulik]

Thank you for the quick response.
I use XE10.1. I can not find this code which you mention in the git repository. In the repository it is without the GetIOHandlerSelf only the CreateOpenSSLSocket:

https://github.com/andremussche/DelphiWebsockets/blob/master/IdServerIOHandlerWebsocket.pas

[andremussche]

Sorry, I just synced my test "Yvi71-pull" branch :) https://github.com/andremussche/DelphiWebsockets/blob/master-Yvi71-pull/IdServerIOHandlerWebsocket.pas 2016-12-02 14:45 GMT+01:00 Tijmen van Gulik <notifications@github.com>:

…

Thank you for the quick response. I use XE10.1. I can not find this code which you mention in the git repository. In the repository it is without the GetIOHandlerSelf only the CreateOpenSSLSocket: https://github.com/andremussche/DelphiWebsockets/blob/master/ IdServerIOHandlerWebsocket.pas — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC5Ijqv8TX5J8JkbkKUOjwyJwYWy2f1fks5rECD1gaJpZM4LCbCh> .

[tijmenvangulik]

Thanks Tijmen

…

Op 2 dec. 2016 om 15:29 heeft André Mussche ***@***.***> het volgende geschreven: Sorry, I just synced my test "Yvi71-pull" branch :) https://github.com/andremussche/DelphiWebsockets/blob/master-Yvi71-pull/IdServerIOHandlerWebsocket.pas 2016-12-02 14:45 GMT+01:00 Tijmen van Gulik ***@***.***>: > Thank you for the quick response. > I use XE10.1. I can not find this code which you mention in the git > repository. In the repository it is without the GetIOHandlerSelf only the > CreateOpenSSLSocket: > > https://github.com/andremussche/DelphiWebsockets/blob/master/ > IdServerIOHandlerWebsocket.pas > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#16 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AC5Ijqv8TX5J8JkbkKUOjwyJwYWy2f1fks5rECD1gaJpZM4LCbCh> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.