Deprecated GitHub actions usage
TWiStErRob opened this issue · 11 comments
Warning: The
set-outputcommand is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Example: https://github.com/TWiStErRob/glide-support/actions/runs/3275044365/jobs/5389377582#step:3:710
Will be solved by #347, because you only use setOutput.
Thanks for bringing this up. Kind of an easy fix. Let's see if the warnings go away
Confirmed fixed! Re-ran the the job I quoted above on the same commit.
- name: Set up Android SDK.
uses: android-actions/setup-android@v2Before:
https://github.com/TWiStErRob/glide-support/actions/runs/3275044365/jobs/5389377582#step:3:710
After:
https://github.com/TWiStErRob/glide-support/actions/runs/3275044365/jobs/5393688733#step:3:708
Thanks for the amazing turnaround.
No need to thank me, that warning would have turned into an error eventually. Now I need to find 20+ different places in other projects where I use set-output manually
Not much: https://github.com/search?q=user%3AViliusSutkus89+set-output&type=code
Example that might help (if you have non-trivial echo): TWiStErRob/net.twisterrob.sun#156
Should I be surprised to still see this error on v2.0.2?
Weird the only usage is here:
https://github.com/android-actions/setup-android/blame/main/src/main.ts#L184
And that's still a valid usage, because the actions/core dependency is 1.10.0, bumped by #347
@ViliusSutkus89 is it possible you didn't do npm install at one point when you rebuild the dist?
I have a recent execution on v2
https://github.com/TWiStErRob/net.twisterrob.sun/actions/runs/4247851865/jobs/7386353596#step:4:8, no warnings.
@kyhule 2.0.2 is really old, the fix only exists in 2.0.10:
https://github.com/android-actions/setup-android/tags
@TWiStErRob Ah sorry about that. This is the first time using GitHub actions. I was using v2.0.2 because that is the version listed as the latest on the actions marketplace. I'll upgrade to v2.0.10 today!
I recommend you just use @v2, then this is not a problem, you get free patches. @ViliusSutkus89 any idea what's missing for recent versions to show up at https://github.com/marketplace/actions/setup-android-sdk-tools?