[PRIORITY] VIT Vellore Parent Login's HTML has changed
prijindal opened this issue · 25 comments
After the update,
inside the course object
JSON is marking attendance as false and is returning an empty array for timings
also class_number is returning null, course_code is returning the title and course_title is returning the class number which is making a lot of confusion
class_number: null,
course_code: "Computer Architecture and Organization",
course_title: "1849",
timings: [ ],
course_type: 1,
attendance: {
supported: false
},
This problem is there for all the courses
Interesting. That should never happen. After which update?
Oh that's why refresh is failing for me as well.
Sent from my Windows Phone
-----Original Message-----
From: "Priyanshu Jindal" notifications@github.com
Sent: 21-07-2015 21:54
To: "aneesh-neelam/VITacademics" VITacademics@noreply.github.com
Subject: [VITacademics] Can't get attendance after the update (#105)
After the update,
inside the course object
JSON is marking attendance as false and is returning an empty array for timings
also class_number is returning null, course_code is returning the title and course_title is returning the class number which is making a lot of confusion
class_number: null,
course_code: "Computer Architecture and Organization",
course_title: "1849",
timings: [ ],
course_type: 1,
attendance: {
supported: false
},
This problem is there for all the courses
—
Reply to this email directly or view it on GitHub.
I don't know, i noticed this today only
but i am guessing after the commits from 19th or 20th
@VinayGupta23 :Are you also getting course title instead of course code?
But all tests have passed, no nulls encountered. Especially for Class Number.
{
"reg_no": "13BEC0749",
"dob": "23031995",
"mobile": "9789052052",
"campus": "vellore",
"semester": "FS",
"courses": [
{
"class_number": null,
"course_code": "Analog Circuit Design",
"course_title": "1420",
"subject_type": "Embedded Theory",
"ltpc": "30003",
"course_mode": "PBL",
"course_option": "Regular",
"slot": "A1+TA1",
"venue": "TT621",
"faculty": "ARUN M - SENSE",
"registration_status": "Registered and Approved",
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 3,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "\r\n\t\t\t\t\r\n\t\t\t\t0 0 2 0 1\r\n\t\t\t\t\r\n\t\t\t",
"course_title": "LBC",
"subject_type": "Regular",
"ltpc": "L31L32",
"course_mode": "TT246",
"course_option": "JOHN PRADEEP D - SENSE",
"slot": null,
"venue": null,
"faculty": null,
"registration_status": null,
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 0,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "Computer Organisation and Architecture",
"course_title": "1391",
"subject_type": "Theory Only",
"ltpc": "30003",
"course_mode": "CBL",
"course_option": "Regular",
"slot": "C1",
"venue": "TT726",
"faculty": "PADMINI T N - SENSE",
"registration_status": "Registered and Approved",
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 1,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "Digital Signal Processing",
"course_title": "1623",
"subject_type": "Embedded Theory",
"ltpc": "30003",
"course_mode": "CBL",
"course_option": "Regular",
"slot": "F1",
"venue": "TT621",
"faculty": "SURESH R - SENSE",
"registration_status": "Registered and Approved",
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 1,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "\r\n\t\t\t\t\r\n\t\t\t\t0 0 2 0 1\r\n\t\t\t\t\r\n\t\t\t",
"course_title": "LBC",
"subject_type": "Regular",
"ltpc": "L49L50",
"course_mode": "TT232",
"course_option": "SURESH R - SENSE",
"slot": null,
"venue": null,
"faculty": null,
"registration_status": null,
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 0,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "Digital Communication",
"course_title": "1566",
"subject_type": "Embedded Theory",
"ltpc": "30003",
"course_mode": "PBL",
"course_option": "Regular",
"slot": "B1+TB1",
"venue": "TT716",
"faculty": "KALAPRAVEEN BAGADI - SENSE",
"registration_status": "Registered and Approved",
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 3,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "\r\n\t\t\t\t\r\n\t\t\t\t0 0 2 0 1\r\n\t\t\t\t\r\n\t\t\t",
"course_title": "LBC",
"subject_type": "Regular",
"ltpc": "L43L44",
"course_mode": "TT135",
"course_option": "KALAPRAVEEN BAGADI - SENSE",
"slot": null,
"venue": null,
"faculty": null,
"registration_status": null,
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 0,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "Antennas and Wave Propagation",
"course_title": "1172",
"subject_type": "Theory Only",
"ltpc": "30003",
"course_mode": "CBL",
"course_option": "Regular",
"slot": "E1",
"venue": "TT331",
"faculty": "RAVI KUMAR C V - SENSE",
"registration_status": "Registered and Approved",
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 1,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "Ethics and Values",
"course_title": "3884",
"subject_type": "Embedded Theory",
"ltpc": "20002",
"course_mode": "CBL",
"course_option": "Regular",
"slot": "G1",
"venue": "TT301",
"faculty": "PRABAKAR S - SSL",
"registration_status": "Registered and Approved",
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 1,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
},
{
"class_number": null,
"course_code": "\r\n\t\t\t\t\r\n\t\t\t\t0 0 2 0 1\r\n\t\t\t\t\r\n\t\t\t",
"course_title": "LBC",
"subject_type": "Regular",
"ltpc": "L11L12",
"course_mode": "TT331",
"course_option": "VIJAYARAJ K - SSL",
"slot": null,
"venue": null,
"faculty": null,
"registration_status": null,
"bill_date": null,
"bill_number": null,
"project_title": null,
"timings": [
],
"course_type": 0,
"attendance": {
"supported": false
},
"marks": {
"supported": false
}
}
],
"refreshed": "2015-07-21T16:32:16.582Z",
"withdrawn_courses": [
],
"cached": false,
"status": {
"message": "Successful execution",
"code": 0
}
}Take a look at the whole file.
Yes i am getting similar data
OK, found the problem.
same
OK, this is a lot of work. The server's scrapers need to be changed.
@aneesh-neelam Btw, an extremely sincere request, don't add J component in LTPC yet. A lot of dependencies will fail such as class duration and credits.
Until all 3 apps are ready for the new LTPJC format, I suggest you can drop the 4th character in the string and send the rest as LTPC.
Later when the apps update, we can add this.
@VinayGupta23: No, not going to do that. Update your apps as soon as possible. Why are you using LTPC anyway? Only thing you need is the P component to get class units.
Yeah, and I'm using C component to get credits for each course. (For CGPA calculator)
Yeah update may take upto a week for me. It will for the other apps as well I guess with other things going on.
Android and iOS apps do not have a CGPA calculator yet. Anyway, this will cause all of the apps to not function for a while. Expect a week of downtime anyway.
Also, clear all data when the user installs the new update. Make the user login again this time, just like what @biocross does everytime.
Hmm. Yeah.
Alright, but I can handle the format change without a re-login. It will automatically start a server refresh when the existing json becomes incompatible, so I don't have to do anything manually.
This is also perfect for implementing #32.
Great, just when I was about to retire from the project, this happens.
Somebody please check if Chennai has also changed. If not, this will be a nightmare.
@aneesh-neelam I don't have any Chennai credentials.
So seriously? A week of downtime?
There are a lot of changes in the Timetable page itself.
Also, they haven't changed anything in the Chennai Campus, the data for different campuses would now be different I guess.
Is there like ANYTHING you can do, like a jugaad just for vellore campus, so that atleast it works for the currently deployed apps?
The apps will also have to be updated.
I'll do that that's not a problem it'll go through expedited review