Quotes around search string
Closed this issue · 7 comments
Search is not performed because Zeal obtains the query with unnecessary single quotes
Pull request submitted with fix for this.
Not sure why, but my pull request was denied. Looks like they don't want it
fixed.
Nathan
On May 8, 2015 10:17 AM, "FlouksBerlin" notifications@github.com wrote:
Still not fixed? :/
—
Reply to this email directly or view it on GitHub
#2 (comment)
.
Thanks for the fix. I applied it to my local copy and it works just fine. Please re-submit your pull request, it's cleearly needed.
Cheers.
confirmed the issue here.
g1ps, would you please post the code/instructions to fix this issue here?
@casterle - In the <os:>\Users\<user>\AppData\Roaming\Brackets\extensions\user\anephew.brackets-zeal\node folder is the ZealDomain.js file.
Change line 26 from:
child_process.exec("zeal --query '" + str + "'", function (error, stdout, stderr) {
to:
child_process.exec("zeal --query " + str, function (error, stdout, stderr) {
You see I've just removed the single quotes from that .exec function.
Thank you!
From: Xhynk [mailto:notifications@github.com]
Sent: Friday, April 15, 2016 14:26
To: anephew/brackets-zeal brackets-zeal@noreply.github.com
Cc: casterle casterle@ccltd.com
Subject: Re: [anephew/brackets-zeal] Quotes around search string (#2)
@casterle https://github.com/casterle - In the \Users\AppData\Roaming\Brackets\extensions\user\anephew.brackets-zeal\node folder is the ZealDomain.js file.
Change line 26 from:
child_process.exec("zeal --query '" + str + "'", function (error, stdout, stderr) {
- to - child_process.exec("zeal --query " + str, function (error, stdout, stderr) {
You see I've just removed the single quotes from that .exec function.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #2 (comment) https://github.com/notifications/beacon/AEvumvUDf-nwSqUdN-DU4V3Qp4Hcl7Gbks5p3_RIgaJpZM4C8Glk.gif