iOS 11 - Xcode 9 beta 6

Question

iOS 11 - Xcode 9 beta 6

adrienbrunwod opened this issue 7 years ago · 11 comments

Using Xcode 9 beta 6 to build my project (toolchain Swift Development Snapshot 2017-08-21), it stopped working. Text from the storyboards is no longer localized.

Answer 1 · 2017-08-26T13:49:36.000Z

I have to download the beta 6 to try this out, but at least in beta 5 (the one I have right now) there is no issue. Have you found the cause?

Answer 2 · 2017-08-28T07:51:10.000Z

Seems like the load method is never called and so neither is the awakeFromNibCustom. But if you have it working with the beta 5 it might be some configuration issue on my end.

Answer 3 · 2017-08-30T10:26:31.000Z

@angelolloqui I can't figure out what changed. Any idea what configuration might have been impacted when trying the beta?

Answer 4 · 2017-09-04T10:28:49.000Z

I'm having similar issue but not always happened. Only happened in a specific flow.

This issue often happened after I opened a WebView with approximate 150MB memory usage in the App, then the Text of UILabel in Xib files would be no longer localized at every page. Not sure this scenario is related to the issue directly or not.

build with Xcode 9 beta 6,7,8 and now using beta 9 the issue is still exist. any idea~?

Thanks.

Answer 5 · 2017-09-05T02:54:09.000Z

Just noticed that this issue may be related to Hot-Patch disabled from Apple's notification recently.

Maybe there's a misjudgment by the runtime method "method_exchangeImplementations" which called by a View with running WebView?

Answer 6 · 2017-09-05T14:59:16.000Z

Could this be an explanation ?
http://jordansmith.io/handling-the-deprecation-of-initialize/

Answer 7 · 2017-09-05T15:10:57.000Z

extension UILabel {
open override func awakeFromNib() {
super.awakeFromNib()
if let text = self.text, text.count > 0 {
self.text = Bundle.main.localizedString(forKey: text, value: "", table: nil)
}
}
}

That seems to work

Answer 8 · 2017-09-05T21:11:31.000Z

The problem with override awakeFromNib in an extension is that it might run into undefined behavior in future versions since overriding into extensions is discouraged. If for example Apple (or a third party sdk) implements that method then yours will not be called (or will be called randomly in exchange of the other).
That is why I decided to go with swizzling, that as far as UIKit runs on objc-runtime should work ok.

Now, seeing that many of you have an issue, we will need to research, but I do not like the fact that it happens after some rare circumstances. It looks like Apple is actually reloading the whole class or doing swizzling themselves (in a wrong way since done properly it could cohexist).

If you want a temporal fix, do what @adrienbrunwod suggested, it should work, but a more consistent solution should be found

Answer 9 · 2017-09-05T21:13:25.000Z

I will try to create a branch tomorrow with the overriding in a category so you can at least import that branch while I find proper time to research (or someone else does)

Answer 10 · 2017-09-07T02:40:43.000Z

I've done a similar workaround in NSObject+AGi18n file.

Thank you @angelolloqui @adrienbrunwod and maybe the issue I encountered will be gone somehow at official iOS 11 :D

Answer 11 · 2017-09-08T18:37:53.000Z

I have added a 0.0.3 version (also to CocoaPods) with the overriding solution. Since it might be temporal, I have included a precompilation header called AGI18N_USE_SWIZZLINGthat when set to 1will use the swizzling again.