ap--/python-seabreeze

Warning message in seabreeze_os_setup should state that it's a known error

LMSC-NTappy opened this issue · 4 comments

LMSC-NTappy commented

spectrometer and system information

  • model: USB2000+
  • operating system: Windows 10 64bit
  • python version: 3.9.1
  • python-seabreeze version: 1.3.0
  • installed-via: conda

current problem

Nothing wrong for me but I got an error upon '''seabreeze_os_setup''' execution, reporting invalid signatures for some of the drivers.

Reporting it because instructed during installation

steps to reproduce

  1. conda install -c conda-forge seabreeze
  2. Restart the anaconda prompt several times, not understanding seabreeze_os_setup fails because it has to be run in admin mode (grating admin at execution time smh doesn't work). Then run anaconda prompt in admin mode
  3. seabreeze_os_setup finally works but outputs a warning telling me I need to report error on github, hence here I am
  4. Using seabreeze as documented! EPIC package man, love it!

minimal code example and error (very helpful if available)

Downloading windows drivers from github
Extracted to temporary directory C:\Users\Attomic\AppData\Local\Temp\seabreeze-os-kro8fz3m
Microsoft PnP Utility

Processing inf :            OOI_ADC1000USB.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_Apex.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_Apex_XP.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_FlameNIR.inf
Adding the driver package failed : The hash for the file is not present in the specified catalog file. The file is likely corrupt or the victim of tampering.

Processing inf :            OOI_FlameU.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_FlameX.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_FlameX_XP.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_Generic_Smartphone_Module.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_HR2000.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_HR2000Plus.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem12.inf

Processing inf :            OOI_HR2000Plus_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem62.inf

Processing inf :            OOI_HR4000.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem47.inf

Processing inf :            OOI_HR4000_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem48.inf

Processing inf :            OOI_Jaz.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem63.inf

Processing inf :            OOI_Jaz_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem64.inf

Processing inf :            OOI_Maya2000.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_Maya2000Pro.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem65.inf

Processing inf :            OOI_Maya2000Pro_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem66.inf

Processing inf :            OOI_MayaLSL.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem67.inf

Processing inf :            OOI_MMSRaman.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_NIR256.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_NIR512.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_NIRQuest256.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem68.inf

Processing inf :            OOI_NIRQuest256_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem69.inf

Processing inf :            OOI_NIRQuest512.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem70.inf

Processing inf :            OOI_NIRQuest512_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem71.inf

Processing inf :            OOI_QE65000.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem72.inf

Processing inf :            OOI_QE65000_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem73.inf

Processing inf :            OOI_QEPRO.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_QEPRO_XP.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_SAS.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_Spark.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_Spark_XP.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_STS.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem74.inf

Processing inf :            OOI_STS_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem75.inf

Processing inf :            OOI_Torus.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem76.inf

Processing inf :            OOI_Torus_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem77.inf

Processing inf :            OOI_USB2000.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem49.inf

Processing inf :            OOI_USB2000Plus.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem78.inf

Processing inf :            OOI_USB2000Plus_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem79.inf

Processing inf :            OOI_USB2000_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem50.inf

Processing inf :            OOI_USB250.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem80.inf

Processing inf :            OOI_USB250_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem81.inf

Processing inf :            OOI_USB325.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem51.inf

Processing inf :            OOI_USB325_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem52.inf

Processing inf :            OOI_USB4000.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem53.inf

Processing inf :            OOI_USB4000_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem54.inf

Processing inf :            OOI_USB500.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem82.inf

Processing inf :            OOI_USB500_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem83.inf

Processing inf :            OOI_USB650.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem55.inf

Processing inf :            OOI_USB650_XP.inf
Successfully installed the driver on a device on the system.
Driver package added successfully.
Published name :            oem56.inf

Processing inf :            OOI_Ventana.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.

Processing inf :            OOI_Ventana_XP.inf
Adding the driver package failed : The third-party INF does not contain digital signature information.


Total attempted:              53
Number successfully imported: 33

Note: Some of the drivers currently don't have valid signatures.
Look at the output above. If the spectrometer you want to use only
provides an unsigned driver, you might have to install it manually.
If you encounter this issue, please report it on github.
pnputil returned with 3758096943
Press [enter] to close.
ap-- commented

Hi @LMSC-NTappy,

Thank you for reporting ❤️
It's a bit funny, because this message has been in python-seabreeze for more than 2 years and you are the first to report 🥇 🎉

The good thing is that everything worked for you out of the box.
Sadly, there's nothing we can do to get newly signed drivers so we could remove this issue. Unless OceanInsight would sign these drivers again.
But, maybe it's worth changing the message in the tool for the next version.

I'll rename the issue and keep it open as a reminder ☺️

Have a great day!
Cheers,
Andreas 😃

ap-- commented

Oh, but reading your message again:

Restart the anaconda prompt several times, not understanding seabreeze_os_setup fails because it has to be run in admin mode (grating admin at execution time smh doesn't work). Then run anaconda prompt in admin mode

this is actually a bug... I have never tested this on 😮 Windows XP 😮
I'll try testing it too in a vm and will add a note to the docs.

Cheers,
Andreas

LMSC-NTappy commented

Hello Andreas,

Oops, reading your message i realized I wrote Windows XP when I meant windows 10. Probably tired on a friday afternoon. ^^

Sorry about that I hope you don't get busy because of this

Have a nice week-end and thanks again for your work, I am a huge fan

Cheers

Nico

ap-- commented

Hi Nico,

ah okay. Hmm... still a bug then. I think I'll add some output to the script so that it's clear it needs to run in an admin shell.
Thanks again for reporting 😃

Cheers,
Andreas