apache/arrow-julia

Incorrect syntax in ArrowTypes code

ericphanson opened this issue · 2 comments

ericphanson commented

arrow-julia/src/ArrowTypes/src/ArrowTypes.jl

Lines 122 to 123 in 8aed969

arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata{T}
arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata{T}

I think this should be

 arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata(T)
 arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata(T)
Moelf commented

We need CI coverage I guess

  • 👍1
baumgold commented

@ericphanson - good catch. #453 for the fix. Apologies for the inconvenience.

  • ❤️1