apex/gateway

Set request.RequestURI

Closed this issue · 5 comments

earthboundkid commented

Request.URL is set, but not Request.RequestURI. This causes problems with certain logging middleware.

piotrkubisa commented

I remember, I got similar issue as you reported in #26 while I was trying to re-use github.com/go-chi/chi/middleware.Logger. In my re-implementation of apex/gateway, I have made a following commit piotrkubisa/apigo@6de39ca. Knowing a fact the API Gateway/Netflify uses HTTPS, it is worth setting *http.Request.TLS = &tls.ConnectionState{} too.

  • 👍1
jainpiyush19 commented

This is failing with https://github.com/dimfield/httptreemux v5 since request.RequestURI must be complete path with query params. Current implementation e.Path only gives the path without query params

  • 👀1
earthboundkid commented

@jainpiyush19 I updated my fork to use the query parameters.

jainpiyush19 commented

@carlmjohnson Thanks. Will you be raising a PR on the main repo?

earthboundkid commented

No, my fork has diverged and I’m not interested in figuring out how to reconcile with apex’s version. But you can probably just cherry-pick it and open a PR if you prefer their version.