arduino/ArduinoCore-megaavr

`digitalWrite` has a wrong signature

Avamander opened this issue · 2 comments

Avamander commented

Currently MegaAVR is one of the very few platforms where digitalWrite doesn't take a boolean for digitalWrite (there's no digitalWrite(uint8_t pin, bool val)), this causes unnecessary incompatibility with a massive selection of libraries out there.

The function's signature should either be changed or the core should overload the function.

MCUdude commented

The latest release (1.8.6) should have this issue fixed.

  • 👍1
Michael-Brodsky commented

So does attachInterrupt and, as usual, there's no actual signature in the docs, just the usual Arduino noob stuff. Usable ISO/IEC style docs would be nice but I guess that would confuse people who think everything should be type 'int'.