artsy/garner

Garner.cache loses namespace options when deleting a record as block yields nil

dblock opened this issue · 2 comments

See #80.

In

Garner.config.cache.delete(compound_key) unless result
:

result = Garner.config.cache.fetch(compound_key, options_hash) do
    yield
end
Garner.config.cache.delete(compound_key) unless result

The fetch here is by compound key with options, but the delete is without the options.

@fancyremarker Is this good? Merge?

@dblock: Yup, LGTM.