VS2022 (Version 17.8.1) can build
Closed this issue · 6 comments
after 'Cmake .' and open and compile from solution get:
Severity Code Description Project File Line Suppression State Details
Error C2039 '_Countl_zero_fallback': is not a member of 'std' fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 113
Error C3861 '_Countl_zero_fallback': identifier not found fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 113
Error C3615 constexpr function 'cxx20::countl_zero' cannot result in a constant expression fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 139
Error C3615 constexpr function 'cxx20::countl_zero' cannot result in a constant expression fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 140
Error C3615 constexpr function 'cxx20::countl_zero' cannot result in a constant expression fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 141
Error C3615 constexpr function 'cxx20::countl_zero' cannot result in a constant expression fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 142
Error C3615 constexpr function 'cxx20::countl_zero' cannot result in a constant expression fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 143
Error C3615 constexpr function 'cxx20::countl_zero' cannot result in a constant expression fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 144
Warning C4067 unexpected tokens following preprocessor directive - expected a newline fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 185
Error C1189 #error: "Not bit_cast support at all implement using std::memcpy" fixed_math D:\UE5\fixed_math-master\fixed_lib\include\fixedmath\detail\utility_cxx20.h 186
What c++ standard are You using in Your project ?
Thx.
Yep there were updates for c++20 and c++23 in library side functionalities, which doesn't affect fixed math functions at all.
So You are safe to revert for c++17, You will not lose anything.
I have to find more time to revert partial support for side functions back on msvc with c++17 in master.
Main project at which this lib is used already moved to c++20 that why I missed backward compatibility for msvc c++17.
Btw it is good to know that actually someone else is using this library, so far I didn't know that at all, I'll keep this in mind.
I fixed master v0.9.17 for using with c++17 masvc, when there is no bitcast support at all it will just not be available and compile with msvc c++17 mode, I can't implement it for msvc c++17 and it is not used in fixedmath at all, it is just side supported function I am using in some project with c++20/17 clang and fixedmath