ascott1/bigSlide.js

Grunt error

Opened this issue · 1 comments

joanvila commented

Hi!

I was making some changes to the repository to contribute but I ran into a problem.

After doing the modifications I had in mind I ran the grunt command to generate the minified files and the the other checks. However, I got this error:

Testing jasmine specs via PhantomJS

exposed internal components
 x Expected '' to be '0px'. (1)
 x Expected '' to be '-200px'. (1)

>> 2 failures
Warning: Task "jasmine:test" failed. Use --force to continue.
Aborted due to warnings.

I am not a grunt or phantomJS expert and I don't recognise this error. If somebody has a clue about it I would appreciate it.

Thanks,
Joan

ascott1 commented

@joanvila

It's likely that your changes caused these two tests to fail:

https://github.com/ascott1/bigSlide.js/blob/master/test/big-slide.spec.js#L134
https://github.com/ascott1/bigSlide.js/blob/master/test/big-slide.spec.js#L125

If those are intended changes, you can update the tests.

Thanks!