asoroosh/DVARS

Different p values from DVARSCalc.m and DVARSCalc_octave.m

BertramW opened this issue · 1 comments

BertramW commented

Running DVARSCalc.m and DVARSCalc_octave.m gave different p values from chi2 tests.

I have made following changes in DVARSCalc_octave.m for having identical results
Uncommenting line 296
X2p = @(x,m,s) 1-chi2cdf(X2stat(x,m,s),X2df(m,s));
Commenting line 296
% X2p = @(x,m,s) chi2cdf(X2stat(x,m,s),X2df(m,s));

asoroosh commented

Hi Bertram, thanks for catching this! This has slipped since Octave chi2cdf() function doesn't have 'upper' option.

I just updated the code:

DVARS/Octave/DVARSCalc_octave.m

Line 306 in 821b522

X2p = @(x,m,s) 1-chi2cdf(X2stat(x,m,s),X2df(m,s));

Thanks again for letting us know!